Fix XcodeVersion() parsing for Xcode 10.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R=dpranke No-Try: True No-Presubmit: True Change-Id: I45f4946778f3f9ca7eef30bcd9c6e714134bcb3f Reviewed-on: https://chromium-review.googlesource.com/1198344 Reviewed-by: Dirk Pranke <[email protected]>
refack
approved these changes
Oct 18, 2018
|
Thank you @pyrtsa |
Changes the output from '0100' to '1000' and fixes the parsing of `CLTVersion()` output too in case `xcodebuild -version` prints an unexpected output.
richardlau
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the output from '0100' to '1000' and fixes the parsing of
CLTVersion()output too in casexcodebuild -versionprints an unexpected output.